[pull] main from Shopify:main - #200
Merged
Merged
Conversation
On web, JsiSkParagraphStyle.toParagraphStyle only ever passed
{ color: BLACK } as the textStyle, silently dropping the default
textStyle provided to ParagraphBuilder.Make (fontFamilies, fontSize,
etc.), so text laid out with the CanvasKit defaults (fontSize 14)
unless a style was pushed explicitly. The native implementation
honors it, so web behaved differently from iOS/Android.
Merge the defined properties of the converted textStyle over the
black-color default (the ParagraphStyle constructor requires a color).
Also includes the node version upgrade from main (#3927).
Release WebGL contexts and GrDirectContexts on web Canvas unmount, reuse them on relayout, and unregister view handles from SkiaViewApi so unmounted views no longer retain their detached canvas elements. Drop pictures set after unmount and guard snapshot calls on unregistered views.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )